{ "changes": [ { "host": "android", "project": "platform/frameworks/support", "creationTime": "1713376006000", "lastModificationTime": "1713376006000", "latestRevision": "89d0df0a7dfe7008c1b575b84a10e048a70f5d13", "revisions": [ { "gitRevision": "89d0df0a7dfe7008c1b575b84a10e048a70f5d13", "commit": { "parents": [ { "commitId": "64e6d7794e2425e3611d0b3e1cf70d252bd7d145" }, { "commitId": "978353a2fc285a51274efbd37061943865bd2513" } ], "author": { "name": "Clara Fok", "email": "clarafok@google.com" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com" }, "subject": "Merge \"Update navDeepLink dsl to take basePath\" into androidx-main", "commitMessage": "Merge \"Update navDeepLink dsl to take basePath\" into androidx-main" } } ], "submittedTime": "1713376006000", "projectPath": "frameworks/support" }, { "host": "android", "project": "platform/frameworks/support", "branch": "androidx-main", "changeNumber": "3044522", "patchset": 7, "status": "merged", "creationTime": "1713297282000", "lastModificationTime": "1713376006000", "latestRevision": "978353a2fc285a51274efbd37061943865bd2513", "revisions": [ { "gitRevision": "978353a2fc285a51274efbd37061943865bd2513", "patchSet": 7, "fetchs": [ { "method": "repo", "url": "platform/frameworks/support", "ref": "refs/changes/22/3044522/7" }, { "method": "http", "url": "https://android.googlesource.com/platform/frameworks/support", "ref": "refs/changes/22/3044522/7" } ], "commit": { "parents": [ { "commitId": "9d030a762063a080c3d16dad5581d45b1ca3e3c1", "subject": "Merge \"[Jetpack] Update nearby gms dependency to 19.2.0\" into androidx-main" } ], "author": { "name": "Clara Fok", "email": "clarafok@google.com" }, "committer": { "name": "Clara Fok", "email": "clarafok@google.com" }, "subject": "Update navDeepLink dsl to take basePath", "commitMessage": "Update navDeepLink dsl to take basePath\n\nThis ensures basePath is set for safe args deeplinks. Any uriPattern that is set within the builder lambda will override the generated uriPattern.\n\nThe builder requires `noinline` or else IDE throws error `Illegal usage of inline-parameter 'deepLinkBuilder...`\n\nNote on lint: navDeepLink must not have empty builder lambdas in the past. Now it is permitted if there is TypeParameter in the case of safe args where the base path for uriPattern is passed in as a param rather than set as a uriPattern within builder.\n\nTest: ./gradlew navigation:navigation-common:cC\nBug: 188693139\nBug: 334995120\nRelnote: \"Safe Args navDeepLink dsl now takes in basePath to ensure base path is set for the final generated uriPattern. Any uriPattern that is set within the builder lambda will override the generated uriPattern.\"\nChange-Id: I8d3948948e68b65f05c5bb943daba3deda64db2e\n", "bugIds": [ "188693139", "334995120" ] }, "creationTime": "1713373544000", "ref": "refs/changes/22/3044522/7", "uploader": { "name": "Clara Fok", "email": "clarafok@google.com", "accountId": "1881715" } } ], "owner": { "name": "Clara Fok", "email": "clarafok@google.com" }, "changeId": "I8d3948948e68b65f05c5bb943daba3deda64db2e", "submittedTime": "1713376006000", "projectPath": "frameworks/support" } ] }