{ "changes": [ { "host": "android", "project": "platform/frameworks/support", "creationTime": "1642100344000", "lastModificationTime": "1642100344000", "latestRevision": "bf73d7ff7b65546c13d94e09acba824218616acc", "revisions": [ { "gitRevision": "bf73d7ff7b65546c13d94e09acba824218616acc", "commit": { "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com" }, "subject": "Merge \"Refactoring focus search and fixing some bugs\" into androidx-main", "commitMessage": "Merge \"Refactoring focus search and fixing some bugs\" into androidx-main" } } ], "projectPath": "frameworks/support" }, { "host": "android", "project": "platform/frameworks/support", "branch": "androidx-main", "changeNumber": "1940140", "patchset": 4, "status": "merged", "creationTime": "1641512485000", "lastModificationTime": "1642100344000", "latestRevision": "b80d458bc8f842ba493086b84d8a68726c3a3302", "revisions": [ { "gitRevision": "b80d458bc8f842ba493086b84d8a68726c3a3302", "patchSet": 4, "fetchs": [ { "method": "repo", "url": "platform/frameworks/support", "ref": "refs/changes/40/1940140/4" }, { "method": "http", "url": "https://android.googlesource.com/platform/frameworks/support", "ref": "refs/changes/40/1940140/4" } ], "commit": { "parents": [ { "commitId": "0904c1d1d893ca5b13f9740e5911639875de04f3", "subject": "Merge changes from topic \"creation_activity\" into androidx-main" } ], "author": { "name": "Ralston Da Silva", "email": "ralu@google.com" }, "committer": { "name": "Ralston Da Silva", "email": "ralu@google.com" }, "subject": "Refactoring focus search and fixing some bugs", "commitMessage": "Refactoring focus search and fixing some bugs\n\nThis cleanup is in preparation to implement a focus cluster.\nFocus Cluster will be added as a new foundation API in a separate CL.\n\nWhen we move focus among children of a deactivated node, we treat the\nnodes as if they are children of the first non-deactivated ancestor.\nInstead of doing that, we should treat children of a deactivated node\nas siblings and move focus among them before visiting other children\nof the non-deactivated ancestor.\n\nI also found a bug in tests that use containsExactly(). The assertion\nonly checks if all the values are present, but does not check if the\nvalues occur in the specified order. We need to use\ncontainsExactly().inOrder() to assert that the items occur in the\nexpected order. I fixed the incorrect tests and added a test util\nfunction to prevent this kind of error from happening in the future.\n\nBug: 213508274\nTest: /gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.OneDimensionalFocusSearchNextTest\nTest: /gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.OneDimensionalFocusSearchPreviousTest\nTest: /gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.TwoDimensionalFocusTraversalTest\nChange-Id: I68f1d0d78d00567b9719e752fa4b9c1c4ec26386\n", "bugIds": [ "213508274" ] }, "creationTime": "1642029031000", "ref": "refs/changes/40/1940140/4", "uploader": { "name": "Ralston Da Silva", "email": "ralu@google.com", "accountId": "1402596" } } ], "owner": { "name": "Ralston Da Silva", "email": "ralu@google.com" }, "changeId": "I68f1d0d78d00567b9719e752fa4b9c1c4ec26386", "submittedTime": "1642100344000", "projectPath": "frameworks/support" } ] }