{ "changes": [ { "host": "android", "project": "platform/frameworks/support", "creationTime": "1669236037000", "lastModificationTime": "1669236037000", "latestRevision": "0f2a75242f51d63e6f51d6d3a6980727fad280a3", "revisions": [ { "gitRevision": "0f2a75242f51d63e6f51d6d3a6980727fad280a3", "commit": { "author": { "name": "Zach Klippenstein", "email": "klippenstein@google.com" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com" }, "subject": "Merge \"Refactor some animation tests to be more imperative and deterministic.\" i", "commitMessage": "Merge \"Refactor some animation tests to be more imperative and deterministic.\" into androidx-main" } } ], "projectPath": "frameworks/support" }, { "host": "android", "project": "platform/frameworks/support", "branch": "androidx-main", "changeNumber": "2313359", "patchset": 2, "status": "merged", "creationTime": "1669150266000", "lastModificationTime": "1669236036000", "latestRevision": "a884270c1a1b8ce55e12fcebf6387c299ceee001", "revisions": [ { "gitRevision": "a884270c1a1b8ce55e12fcebf6387c299ceee001", "patchSet": 2, "fetchs": [ { "method": "repo", "url": "platform/frameworks/support", "ref": "refs/changes/59/2313359/2" }, { "method": "http", "url": "https://android.googlesource.com/platform/frameworks/support", "ref": "refs/changes/59/2313359/2" } ], "commit": { "parents": [ { "commitId": "d182d8af38f407dcb35599126c6c7534381abe25", "subject": "Merge \"Update metalava version in AndroidX to 1.0.0-alpha07\" into androidx-main" } ], "author": { "name": "Zach Klippenstein", "email": "klippenstein@google.com" }, "committer": { "name": "Zach Klippenstein", "email": "klippenstein@google.com" }, "subject": "Refactor some animation tests to be more imperative and deterministic.", "commitMessage": "Refactor some animation tests to be more imperative and deterministic.\n\nAnimatedContentTest.AnimatedContentSlideInAndOutOfContainerTest:\nThe assertions were written inside a LaunchedEffect for each branch of\nthe transition. The test actually runs two transitions in a row, with\ndifferent assertions for each run, but those were all embedded in the\nsame LaunchedEffect and triggered by comparing and setting some state in\na recomposition. This made the test hard to follow and update. I pulled\nthe state writes that trigger the animations, as well as the assertions,\nout and used explicit advanceByFrame calls.\n\nAnimatedVisibilityTest.testTransitionExtensionAnimatedVisibility:\nThe test was using tween animations with the default easing, which is\nharder to write assertions around because due to the curve the animation\ncan reach final values before the animation duration is complete. I\nchanged the animation to use LinearEasing instead, and updated the test\nassertions accordingly (e.g. the content will be completely removed from\nthe composition when hidden instead of being measured with zero size).\n\nOther changes are using Truth for assertions and auto-formatting from\nAndroid Studio.\n\nTest: AnimatedContentTest, AnimatedVisibilityTest\nChange-Id: Iee546c24ab1ead7805968e3cf5a92ca6df6fcf10\n" }, "creationTime": "1669150291000", "ref": "refs/changes/59/2313359/2", "uploader": { "name": "Zach Klippenstein", "email": "klippenstein@google.com", "accountId": "1894606" } } ], "owner": { "name": "Zach Klippenstein", "email": "klippenstein@google.com" }, "changeId": "Iee546c24ab1ead7805968e3cf5a92ca6df6fcf10", "submittedTime": "1669236036000", "projectPath": "frameworks/support" } ] }