{ "changes": [ { "host": "android", "project": "platform/frameworks/support", "creationTime": "1674600787000", "lastModificationTime": "1674600787000", "latestRevision": "3ca9c370522a2d08bd7279c4aecc35f36734fe5c", "revisions": [ { "gitRevision": "3ca9c370522a2d08bd7279c4aecc35f36734fe5c", "commit": { "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com" }, "subject": "Merge \"Check whether streamUseCase is supported by the device before setting it.", "commitMessage": "Merge \"Check whether streamUseCase is supported by the device before setting it.\" into androidx-main" } } ], "projectPath": "frameworks/support" }, { "host": "android", "project": "platform/frameworks/support", "branch": "androidx-main", "changeNumber": "2396204", "patchset": 3, "status": "merged", "creationTime": "1674185814000", "lastModificationTime": "1674600786000", "latestRevision": "2da5c09bfebc9a524199414d0e83cfeca65fdb51", "revisions": [ { "gitRevision": "2da5c09bfebc9a524199414d0e83cfeca65fdb51", "patchSet": 3, "fetchs": [ { "method": "repo", "url": "platform/frameworks/support", "ref": "refs/changes/04/2396204/3" }, { "method": "http", "url": "https://android.googlesource.com/platform/frameworks/support", "ref": "refs/changes/04/2396204/3" } ], "commit": { "parents": [ { "commitId": "3664583ec5c0bc6b2b358f712cda72fa6632b443", "subject": "Merge \"CameraInteropDeviceStateCallbackRepository in Camera-pipe-integration\" into androidx-main" } ], "author": { "name": "David Jia", "email": "davidjia@google.com" }, "committer": { "name": "David Jia", "email": "davidjia@google.com" }, "subject": "Check whether streamUseCase is supported by the device before setting it.", "commitMessage": "Check whether streamUseCase is supported by the device before setting it.\n\nThis CL addresses two bugs:\n1. There was a bug where since sessionConfig.getImplementationOptions().retrieveOption(STREAM_USE_CASE_OPTION) would return -1 even without Camera2Interop interactions as -1 is set as the default value, in StreamUseCaseUtil.populateSurfaceToStreamUseCaseMapping(), this check would always pass, and so CameraX never sets any streamUseCase values on its own without Camera2Interop\n\n2. We did not check from CameraCharacteristics whether the streamUseCases we are setting are supported or not. We should check if they are available via the key SCALER_AVAILABLE_STREAM_USE_CASES.\n\nBoth bugs are fixed and additional tests are added to verify these situations.\n\nTest: StreamUseCaseTest.java\nChange-Id: I75ead8f1884e37c0c0a0a07b527ae8b72606cd8f\n" }, "creationTime": "1674598545000", "ref": "refs/changes/04/2396204/3", "uploader": { "name": "David Jia", "email": "davidjia@google.com", "accountId": "1951251" } } ], "owner": { "name": "David Jia", "email": "davidjia@google.com" }, "changeId": "I75ead8f1884e37c0c0a0a07b527ae8b72606cd8f", "submittedTime": "1674600786000", "projectPath": "frameworks/support" } ] }