{ "changes": [ { "host": "android", "project": "platform/frameworks/support", "creationTime": "1679068416000", "lastModificationTime": "1679068416000", "latestRevision": "a0b0989c4abc19a9e1440c39dfbbe2a0e39786e8", "revisions": [ { "gitRevision": "a0b0989c4abc19a9e1440c39dfbbe2a0e39786e8", "commit": { "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com" }, "subject": "Merge \"Ensure that clickable and corner radius work together properly\" into andr", "commitMessage": "Merge \"Ensure that clickable and corner radius work together properly\" into androidx-main" } } ], "projectPath": "frameworks/support" }, { "host": "android", "project": "platform/frameworks/support", "branch": "androidx-main", "changeNumber": "2471613", "patchset": 5, "status": "merged", "creationTime": "1678122109000", "lastModificationTime": "1679068416000", "latestRevision": "5c419d77218f6266fc65942c7f28bb2ad3679e47", "revisions": [ { "gitRevision": "5c419d77218f6266fc65942c7f28bb2ad3679e47", "patchSet": 5, "fetchs": [ { "method": "repo", "url": "platform/frameworks/support", "ref": "refs/changes/13/2471613/5" }, { "method": "http", "url": "https://android.googlesource.com/platform/frameworks/support", "ref": "refs/changes/13/2471613/5" } ], "commit": { "parents": [ { "commitId": "ac3737b9673ab94ea26de362fdc349303f345c9d", "subject": "Merge \"Unhide LocalStorage.createGlobalSearchSession.\" into androidx-main" } ], "author": { "name": "Shamali P", "email": "shamalip@google.com" }, "committer": { "name": "Shamali P", "email": "shamalip@google.com" }, "subject": "Ensure that clickable and corner radius work together properly", "commitMessage": "Ensure that clickable and corner radius work together properly\n\nChanges include:\n1. Hoist corner radius modifier to the Box (similar to the size modifiers) so that ripples take right shape\n2. Use image to implement background (imgprovider) with fillBounds similar to other content scales - to simply logic (screenshot test for drawable background passed) as well as to make it easier in future if we wish to support color filter for background images (e.g could be useful to implement clickable boxes + bg drawables + color filter emulating variations of buttons.\n3. Refactor the transformBgImageAndActionRipple function to use modifiers immediately on extracting them for readability.\n\nBug: b/269642297\nTest: Screenshot tests & GART for drawable backgrounds, ripple demo widget, existing GlanceAppWidgetViewAdapterTest\nChange-Id: Ic19762963518389c9deb5bfe5a84cc2e7828d1b2\n", "bugIds": [ "269642297" ] }, "creationTime": "1678123849000", "ref": "refs/changes/13/2471613/5", "uploader": { "name": "Shamali Patwa", "email": "shamalip@google.com", "accountId": "1976990" } } ], "owner": { "name": "Shamali Patwa", "email": "shamalip@google.com" }, "changeId": "Ic19762963518389c9deb5bfe5a84cc2e7828d1b2", "topic": "ripple-corner-radius", "submittedTime": "1679068416000", "projectPath": "frameworks/support" } ] }