{ "changes": [ { "host": "android", "project": "platform/frameworks/support", "creationTime": "1679096734000", "lastModificationTime": "1679096734000", "latestRevision": "508947680f7b32739e5c1e29a9c7ce6fcf3a9784", "revisions": [ { "gitRevision": "508947680f7b32739e5c1e29a9c7ce6fcf3a9784", "commit": { "author": { "name": "Treehugger Robot", "email": "treehugger-gerrit@google.com" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com" }, "subject": "Merge \"Partial Revert \"Use LineHeightStyle as default for includeFontPadding=tru", "commitMessage": "Merge \"Partial Revert \"Use LineHeightStyle as default for includeFontPadding=true\"\" into androidx-main" } } ], "projectPath": "frameworks/support" }, { "host": "android", "project": "platform/frameworks/support", "branch": "androidx-main", "changeNumber": "2495022", "patchset": 5, "status": "merged", "creationTime": "1679071359000", "lastModificationTime": "1679096734000", "latestRevision": "9cd31139e2e765a14377fe5d3fa2a77db178c8de", "revisions": [ { "gitRevision": "9cd31139e2e765a14377fe5d3fa2a77db178c8de", "patchSet": 5, "fetchs": [ { "method": "repo", "url": "platform/frameworks/support", "ref": "refs/changes/22/2495022/5" }, { "method": "http", "url": "https://android.googlesource.com/platform/frameworks/support", "ref": "refs/changes/22/2495022/5" } ], "commit": { "parents": [ { "commitId": "c86c04c3f52ef216ff67d87be1a3c64c2fab934d", "subject": "Merge \"Make text:text classes internal\" into androidx-main" } ], "author": { "name": "Siyamed Sinir", "email": "siyamed@google.com" }, "committer": { "name": "Siyamed Sinir", "email": "siyamed@google.com" }, "subject": "Partial Revert \"Use LineHeightStyle as default for includeFontPadding=true\"", "commitMessage": "Partial Revert \"Use LineHeightStyle as default for includeFontPadding=true\"\n\nThis reverts commit 5ddf42b0308c9c64303dd378baae8b13aa1f5614.\n\nReason for revert: In cases with multi style text with different \nsize annotations, top/bottom calculation ends up different. \nAnother minor side effect was that there was 1px height diff in \nsome screenshot tests.\n\nThe changes in LineHeightStyleSpan as a result of the previous review \nare not reverted.\n\nTest: TreeHugger\nTest: Following tests on Android 11 and 13\nTest: ./gradlew text:text:test\nTest: ./gradlew text:text:cAT\nTest: ./gradlew compose:ui:ui-text:test\nTest: ./gradlew compose:ui:ui-text:cAT\n\nChange-Id: I24f5e94622b220cce3db1df5f5e7eedbc385f94d\n" }, "creationTime": "1679091237000", "ref": "refs/changes/22/2495022/5", "uploader": { "name": "Siyamed Sinir", "email": "siyamed@google.com", "accountId": "1106808" } } ], "owner": { "name": "Siyamed Sinir", "email": "siyamed@google.com" }, "changeId": "I24f5e94622b220cce3db1df5f5e7eedbc385f94d", "submittedTime": "1679096734000", "projectPath": "frameworks/support" } ] }